git ssb

16+

Dominic / patchbay



Clicking "view sorce"-gears switches to an open git repo tab

%C4ZwTmWlJoNMmBgSlBika92xvpU9a9/4025bgdERHXc=.sha256
Openkeks opened this issue on 2/6/2017, 12:12:13 AM

Clicking "view sorce"-gears switches to an open git repo tab

When having a git repo open in one tab and I click a "show source" gear in another tab, patchbay switches to the git repo.

%t1en5fSLd+sErQTHLHLVnn/A7NG6JFkZUl1g9jbZy7Q=.sha256 mixmix · 2/6/2017, 12:37:46 AM

can you give me a link to a message which behaves like this plz @keks ?

%9ePbo88Nj26nBiz5lDH5ViemqNq2r9IzWP2tig74JeI=.sha256 keks · 2/6/2017, 10:38:31 AM

%t1en5fS... ;)

I think its any message for me...

%FV34bmdzt3WHEY7vV1jtPDzbMWQhoEgp0oBGAyrcRmY=.sha256 dinoworm ๐Ÿ› · 2/6/2017, 10:48:51 AM

for me right now, clicking "view source"-gears switches me to the /network tab that i have open.

%zCP3QiC1JWoHeYOnvXxtXgXN5OBH6tjlBN1WXI5MZlQ=.sha256 keks · 2/6/2017, 10:54:47 AM

for me right now, clicking "view source"-gears switches me to the /network tab that i have open.

That is not happening here o.O

I'm on 6.7.4 / 5840ace3e723ac68ca995db5a3598cb2ac264c83

%f14ByUH/BEPwy3pyWhmTh2YY05CygHdJLRFmkLjEtl8=.sha256 mixmix · 2/6/2017, 11:21:14 AM

I'm having a hard time replicating this D:

%Rx+DmgIl7S4KrLP4sT1J8nF39pOGBCRPtl4QcnQWzHY=.sha256 keks · 2/9/2017, 8:17:14 PM

:( Do you have the same listeners? listeners.png

%xdAyJ6ESpokgB8/FRwwBEjJlnumLA1FHP4SddlAFgY4=.sha256 mixmix · 2/9/2017, 9:31:13 PM

not at all ! This is what I see in electron .. in 6.9.2

Selection_207.png

have you run npm upgrade ?

%7mGG5MZ6DB/vXDlR90ltGh4oeE4IzmLcHbCjjpjkzOU=.sha256 keks · 2/10/2017, 4:39:28 PM

oh I mean this are the listeners for the gear <a>.

I'm currently on patchbay 6.7.4. I have the git repo cloned and do a git pull && npm i every now and then. I'll try upgrading now, hang on

%Hck8gpX1fggtdh5Qy242UCTjTmofhe9YJFTCk0X0hAc=.sha256 keks · 2/10/2017, 4:49:38 PM

Just updated, I'm on master. The problem remains. I just removed all the event listeners on the gear and it keeps happening (the source doesn't show anymore though, so it worked). I made screenshots of the listeners before and after opening a git repo, and there are differences!

before: beforegit.png

after: aftergit.png

%OeYHvMR5Sdc29TmUQHUBU3Fra/zmFIWrEmaLOfw4CEs=.sha256 mixmix · 2/10/2017, 9:54:45 PM

still no success replicating this.

to be clear, the steps I follow are:

  1. open the /git-ssb tab, select %catstack (a git repo page)
  2. got to /public tab, click on a gear on any message

And I expect to be taken back to %catstack ?

I am still not seeing the same event listeners as you, though with logging can confirm the listeners are being attached, and the gear click is triggering the keyscroll.js onActivateChildbut does not run selectChild

@mikey do you have any recommendations for debugging this? @keks to try something desperate can you scrap your node_modules and npm i afresh?

%/F9kkx8bSgiy95zEb2IZWR9A5QtOhB3LCi4H0jiILTE=.sha256 keks · 2/12/2017, 4:43:20 PM

:/

to be clear, the steps I follow are:

  1. open the /git-ssb tab, select %catstack (a git repo page)
  2. got to /public tab, click on a gear on any message

And I expect to be taken back to %catstack ?

Exactly.

@keks to try something desperate can you scrap your node_modules and npm i afresh?

I'll do that, but not now...

Built with git-ssb-web