git ssb

1+

cel / pull-hash



call onEnd before cb

%sH2Angnq3IyKu3DdpKnY0OXw61+pFMslBSDlLms541o=.sha256
ClosedDominic opened this issue on 4/25/2016, 9:25:06 AM

it would be more useful to callback to onEnd before cb, so that uses like this is possible:

      pull(
        File(blob),
        Hash('sha256', function (_, _id) {
          id = _id
        }),
        pull.drain(null, function (err) {
          if(err) throw err
          console.log(hash)
        })
      )

Unless there is something async after pull-hash, id won't be available. I would make a pr to fix this but currently in the process of getting ssb-blobs working right and that is interfeering

%Km1aiFdwdBKoBQ1oBwjascnEb26rz0cy7UJwkM+w/0c=.sha256 cel · 4/25/2016, 11:11:09 AM

I agree, this would be good. I think I worked around it once using multicb.

%vzzypKDl4LR++9ZWFn0ejtbGn65nkKFBkQoHTZJkIUs=.sha256 Dominic · 4/25/2016, 11:12:19 PM

I have a fix on my fork, but I pull requests arn't working for me yet

%9WT9oL7f5mYrEgqkthYI60MVnVVNYjqJ8J3Z/4SPG30=.sha256 cel closed this issue · 11/30/2016, 7:09:48 PM

this is merged

Built with git-ssb-web