git ssb

30+

cel / git-ssb-web



crash when attempting to create a pull request

%pPqJJh2iDxfXsTU4NAnHFqfORPjEU0mdUJeSU0uravc=.sha256
ClosedDominic opened this issue on 4/25/2016, 10:49:07 PM

when I click on the new pull request button, I get this error:

/home/dominic/c/ssb-blobs/node_modules/git-ssb-web/lib/repos/pulls.js:237
        cb(null, branchMenu(repo, 'base', base = ref || 'HEAD'))
                 ^

ReferenceError: branchMenu is not defined
    at gotBase (/home/dominic/c/ssb-blobs/node_modules/git-ssb-web/lib/repos/pulls.js:237:18)
    at /home/dominic/c/ssb-blobs/node_modules/pull-git-repo/index.js:692:7
    at abortCb (/home/dominic/c/ssb-blobs/node_modules/pull-stream/sources.js:8:3)
    at /home/dominic/c/ssb-blobs/node_modules/pull-stream/sources.js:17:14
    at next (/home/dominic/c/ssb-blobs/node_modules/pull-git-repo/index.js:688:5)
    at /home/dominic/c/ssb-blobs/node_modules/pull-stream/sources.js:20:7
    at Repo.R.getSymRef (/home/dominic/c/ssb-blobs/node_modules/pull-git-repo/index.js:684:3)
    at /home/dominic/c/ssb-blobs/node_modules/git-ssb-web/lib/repos/pulls.js:234:17
    at Array.<anonymous> (/home/dominic/c/ssb-blobs/node_modules/git-ssb-web/lib/util.js:23:5)
    at next (/home/dominic/c/ssb-blobs/node_modules/pull-cat/index.js:28:19)

git-ssb@1.2.3

Dominic mentioned this issue in I have a fix on my fork, but I [pull requests arn't working for me yet](%pPqJJh2iDxfXsTU4NAnHFqfORPjEU0mdUJeSU0uravc=.sha256)
cel mentioned this issue · 4/26/2016, 6:22:22 AM
Fix bugs with pull requests
%RbfT/Ez5rI1Ue6rI3pi8gDdX+q1auZVRHJS6nImw/cs=.sha256 cel · 4/26/2016, 6:29:32 AM

this should be fixed now in git-ssb-web@1.13.2 @dominic can you confirm if it works after updating?

%/DEu34CLYLZHoaDn24RLsl2B2F400yzpD8Fh3uHxeC8=.sha256 cel closed this issue · 6/10/2016, 5:07:31 PM

Built with git-ssb-web