git ssb - open.isExternal() gives a false positive for undefined/null

Henry committed on 1/11/2017, 12:22:50 AM
Parent: 33d49d724c13b515841075e0ae6d096034c78275

changed

modules_core/tabs.jsView
		@@ -94,9 +94,9 @@
94	94 …	if (link.getAttribute('href') === '#') return
95	95 …
96	96 …	//open external links.
97	97 …	//this ought to be made into something more runcible
98		- if(open.isExternal(link.href)) return api.external_confirm(link.href)
	98 …	+ if(link.href && open.isExternal(link.href)) return api.external_confirm(link.href)
99	99 …
100	100 …	if(tabs.has(path))
101	101 …	return tabs.select(path, !ev.ctrlKey, !!ev.shiftKey)
102	102 …

Dominic / patchbay