git ssb

This pull-request fixes the local replication bug. :fireworks:

Also I bumped ssb-ws to the latest version.

Once this is merged we can close: %X+4lAR6...

and we can close %WULXhOs...

I'm looking for testers for this patch, if anyone has time today.

It should fix the local replication bug, which leads to other performance improvements because sbot isn't booting local peers every 3 seconds.

Local replication is working with this patch, and my pub (which has local peers, because of how Ramnode works) is much more responsive now.

I don't have any local connections but I can test if is has any negative consequences if not and so far it has been running fine for me.

From my understanding, it looks like all this patch does is stop attempting to connect to pubs if there is already a local peer connection. Am I missing something? Or does this have some interesting emergent properties?

@matt

it looks like all this patch does is stop attempting to connect to pubs if there is already a local peer connection.

This is not what I'm experiencing. What was happening before I changed this code was sbot was stopping the local connection as soon as it connected.

While I do not quite understand the full extent of what is happening here, my sbot does continue to connect to remote pubs even with a local connection with this patch.

Here's the last few lines of my sbot log

x.x.x.Connected ssb.badran.net.nz:8008:@+hGSCBZrKuzB/y4KzsIoGrw03fNlVj8kyYLIB2oFtAw=.ed25519
x.x.x.x.x.Connected 120.138.27.120:43761:@uIL3USK7QJg5AHohnZC329+RXS09nwjc24ulFBH2Ngg=.ed25519
Connected pi.bret.io:8008:@j3qWwQrWPzTM9zNgk0SI0FcqP1ULGquuINYEWfL330g=.ed25519
Connected 120.138.27.120:43761:@uIL3USK7QJg5AHohnZC329+RXS09nwjc24ulFBH2Ngg=.ed25519
x.Connected 192.168.1.65:8008:@ya/sq19NPxRza5xtoqi9BilwLZ7HgQjG3QpcTRnGgWs=.ed25519
Connected 192.168.1.65:8008:@ya/sq19NPxRza5xtoqi9BilwLZ7HgQjG3QpcTRnGgWs=.ed25519
Connected 192.168.1.65:8008:@ya/sq19NPxRza5xtoqi9BilwLZ7HgQjG3QpcTRnGgWs=.ed25519
Connected 192.168.1.65:8008:@ya/sq19NPxRza5xtoqi9BilwLZ7HgQjG3QpcTRnGgWs=.ed25519
Connected 188.166.252.233:8008:@uRECWB4KIeKoNMis2UYWyB2aQPvWmS3OePQvBj2zClg=.ed25519
x.x.x.x.x.Connected eight45.net:8008:@eM4e8pmRiZpeCBitqp6vq3lT8EwC5UjjKuajHbpWnNI=.ed25519

I'm connected to @gb and I've continued to connect to other pubs. Not sure why if this isn't what the code is saying?

I do see that I'm having multiple connection attempts to the local client still, so maybe there's still something that be improved here?