dinoworm π@6ilZq3kN0F+dXFHAPjAwMm87JEb/VdB+LC9eIMW3sa0=.ed25519
Nextsweeet! i'm not sure i understand the following changes:
diff --git a/modules_basic/invite.js b/modules_basic/invite.js index d4f9ef5..8500f9c 100644 --- a/modules_basic/invite.js +++ b/modules_basic/invite.js @@ -52,7 +52,7 @@ exports.create = function (api) { //if they already follow us, just check we actually follow them. if(err) api.follower_of(id, data.key, function (_err, follows) { - if(follows) cb(err) + if(follows) { location.hash = '' } else next() }) else next()
what's this about?
diff --git a/modules_basic/private.js b/modules_basic/private.js index ce99f1c..33283f9 100644 --- a/modules_basic/private.js +++ b/modules_basic/private.js pull( - u.next(api.sbot_log, {old: false, limit: 100}), + api.sbot_log({old: false}),
why remove
u.next
?diff --git a/package.json b/package.json index 943a0af..e1890ba 100644 --- a/package.json +++ b/package.json @@ -13,7 +13,7 @@ "depject": "^3.0.0", "hjson": "^2.0.3", "human-time": "0.0.1", - "hypercombo": "^0.1.2", + "hypercombo": "0.1.0", "hypercrop": "^1.0.1", "hyperfile": "^1.1.0", "hyperlightbox": "^0.1.3"
why the downgrade?
churrrrr :cat:
hey @cryptop, should we merge f4239eff913ab420f103072dc056ea1f21ac2162 and ba0729cff13a1aa925969da710b076ccaaced546?
if merged, closing!
hey @mix, we merged this in with %4+AvImO..., so closing.
looks good to me, so merged! thanks @arj. :smiley:
hey @dominic, so i'm trying this again but have hit a snag: if a module needs to use the config during create (for example, see
modules_core/blob-url.js
) then it errors withdepject.first: plugins not loaded yet
. i think the same would apply to the other base modules i made so far:keys
andself_id
. can this be resolved if we applied the modules in dependency order, rather than in order added? thanks. :smile:
got it to run after changing:
diff --git a/package.json b/package.json index e8454fe..28b3c6b 100644 --- a/package.json +++ b/package.json @@ -14,7 +14,8 @@ "cont": "~1.0.3", "deep-equal": "^1.0.1", "explain-error": "~1.0.1", - "flumeview-reduce": "^0.2.1", + "flumeview-reduce": "^1.0.1", + "graphreduce": "^2.0.0", "has-network": "0.0.0", "ip": "^0.3.3", "level-memview": "~0.0.0",
it somewhat worked, as in i could get patchbay to load once, but then i kept getting
expected previous: ... found: ...
log statements and browsing togit ssb web
wouldn't load.also i wonder if it's possible to have a migration script, since the re-indexing loses all the "message received" timestamps, which really messes with patchbay and kinda loses previous information, but also definitely only a nice-to-have.
anyways, this is cool, i really like the direction of
flumedb
.
merging!
Built with git-ssb-web