git ssb

10+

Matt McKegg / patchwork



local peers not updating

%HkCG40cJUd/jgN2/zWAXCd4D8mZI+6u0Jyuz5p15xK0=.sha256
Opendinoworm ๐Ÿ› opened this issue on 11/2/2016, 5:06:39 AM

local peers not updating

i was just co-working with @mixmix, who is no longer here but his identity still shows up as a local peer. earlier, when he already had patchwork open and i came online, i didn't show up as a local peer on his patchwork although he did on mine.

%UaxsQqWiTKiB3Rticq2z7R5NfLs+w8Ztg3N5FXdyHbc=.sha256 Matt McKegg · 11/2/2016, 5:15:34 AM

Yeah this is pretty shoddy right now. Currently it will display the local peer (once discovered) until you restart.

@dominic any ideas about reliable detection of local peers (and knowing when they're no longer around)?

%xueKlGK/WQ086XUQG4jPhGIPzHzZ4kVG86cJTbJzkus=.sha256 dinoworm ๐Ÿ› · 11/2/2016, 5:27:07 AM

i thought i remember this working on Patchwork classic, although maybe that wasn't the case.

doing some code archeology i see some peer.connected = false, which i see is now represented as peer.state = undefined.

keen to do some testing at Art~Hack tomorrow to test these code paths and see if we can get reliable connection and disconnection events.

%jGRGr+aF4a8SbnvLjw2zJPkADfbm1gR+z7K38+ix/sc=.sha256 Matt McKegg · 11/4/2016, 1:19:11 PM

Okay this should be working really well now!

And syncing to peers seems to work fairly well too. If you don't follow them it may take a minute or two, but eventually happens.

Closing :boom:

Built with git-ssb-web