git ssb

0+

Piet / ssb-loomio



Commit ca77c54d481c41a3dbb9f2c43454de9dd9dde4c1

Merge branch 'master' of github.com:ssbc/scuttle-poll

Piet Geursen committed on 6/6/2018, 4:19:08 AM
Parent: 3ab10d83371e7fb6a97e4b0a23ded460ab8e01de
Parent: c46ad9c39623cd98b6cbb308d0c0870f15ff701c

Files changed

NOTES.mdchanged
methods.jschanged
package-lock.jsonchanged
package.jsonchanged
NOTES.mdView
@@ -18,11 +18,23 @@
1818
1919 - Vertical slice
2020 - Design for front end dev
2121 - Decorate
22 + - could be painful to maintain / needs a clear spec
2223 - Opinionated folder structure. Human readable API.
2324 - Testing
2425 - Linting with ale
2526 - Give your test files `*.test.js` filenames. It helps with readability when there are errors.
2627 - the inject pattern
2728 - prefer passing a single object rather than ordered args
2829 - don't modify data passed into a function
30 +- Observables:
31 + - making everying obs takes A LOT of time
32 + - could just make async cb, then have a pull stream which announces updates. On update, re-run async cb, or whatever
33 + - could write an async cb which takes a `refresh` function which gets run when there's a change.
34 + - not everything really needs live updates
35 + - not that important:
36 + - body / title / choices (none of these can change)
37 + - important:
38 + - new positions / results
39 + - closesAt
40 + - when I post a new position (should update view)
methods.jsView
@@ -3,11 +3,16 @@
33
44 module.exports = {
55 poll: {
66 async: {
7 + get: require('./poll/async/get'),
78 publishChooseOne: require('./poll/async/publishChooseOne'),
8- get: require('./poll/async/get')
9 + publishUpdatedClosingTime: require('./poll/async/publishUpdatedClosingTime')
910 },
11 + // NOTE - we think this is a bad idea, planning to deprecate
12 + // obs: {
13 + // get: require('./poll/obs/get')
14 + // },
1015 sync: {
1116 isPoll: () => isPoll,
1217 isChooseOnePoll: () => isChooseOnePoll
1318 // Poll: // this is not exported - doesn't follow the inject pattern atm
package-lock.jsonView
The diff is too large to show. Use a local git client to view these changes.
Old file size: 194817 bytes
New file size: 194817 bytes
package.jsonView
@@ -1,7 +1,7 @@
11 {
22 "name": "scuttle-poll",
3- "version": "1.0.2",
3 + "version": "1.0.3",
44 "description": "Create and vote on polls on ssb",
55 "main": "index.js",
66 "scripts": {
77 "test": "tape 'test/**/*.js' | tap-spec"

Built with git-ssb-web