Commit afbb585e6580d4380af3a1b490efb8e6d05feeda
Update line-comment schema doc
cel committed on 11/24/2017, 4:38:12 AMParent: 43dad83091a92312dae090491ec32afd06fc8de9
Files changed
| schemas.md | changed |
| schemas.md | |||
|---|---|---|---|
| @@ -3,17 +3,22 @@ | |||
| 3 | 3 … | ``` | |
| 4 | 4 … | { | |
| 5 | 5 … | "type": "line-comment", | |
| 6 | 6 … | "text": string, | |
| 7 … | + "mentions": Links, | ||
| 7 | 8 … | "repo": MsgId, | |
| 8 | - "updateId": MgsIds, | ||
| 9 … | + "updateId": MsgId, | ||
| 10 … | + "commitId": string, | ||
| 11 … | + "filePath": string, | ||
| 9 | 12 … | "line": number, | |
| 10 | 13 … | } | |
| 11 | 14 … | ``` | |
| 12 | 15 … | `repo`: id of `git-repo` | |
| 16 … | +`text`: text of the comment | ||
| 17 … | +`mentions`: mentions links associated with the text, as done with `post` messages | ||
| 13 | 18 … | `updateId`: id of a `git-update` message that pushed the git commit, git trees, and git blobs needed to render the diff. | |
| 14 | 19 … | `commitId`: commit that the comment is on | |
| 15 | 20 … | `filePath`: path to the file that the comment is on | |
| 16 | 21 … | `line`: line number of the file that the comment is on | |
| 17 | 22 … | ||
| 18 | -Replies to a line comment should be messages of type `post` with `root` | ||
| 19 | -linking to the `line-comment` message. | ||
| 23 … | +A reply to a line comment should be a message of type `post` with `root` | ||
| 24 … | +property set to the id of the `line-comment` message. `branch` property should follow the semantics of `branch` used in other `post` message threads. | ||
Built with git-ssb-web