git ssb

10+

Matt McKegg / patchwork



close all processes when main window is closed

%6M6g6174dJoJwGaUveNf8VGGUjfElwh28eu6PUM5xdY=.sha256
Closed dinoworm ๐Ÿ› wants to merge commits into master from close-all-processes-when-main-window-is-closed
dinoworm ๐Ÿ› · 11/2/2016, 5:58:40 AM

close all processes when main window is closed

use case: i want to close patchwork-next

steps:

  1. i open patchwork-next and have fun using it
  2. i click the close button (varies by window manager)

expected behavior: on anything other than macOS, patchwork-next and all sub-processes exit

actual behavior: the window closes but sub-processes continue to run

%fYZhMSeWeas9OimeaDkByUjjzIp4GIAGBvVbQ7MKaog=.sha256 Matt McKegg · 11/2/2016, 9:09:40 AM

What do you think about putting it in the system tray? I have been thinking about doing this in Ferment.

That would bring the behavior on macOS and other platforms in line. Nice being able to keep syncing in the background, or use git-ssb, etc

But maybe this is me misunderstanding how people use "not mac"? I suppose on most other platforms, minimise doesn't suck and can be used instead.

Matt McKegg deleted the close-all-processes-when-main-window-is-closed branch · 11/2/2016, 9:16:04 AM
%7Opo5s+5v+HVnEZyJ1FBGjzXhg57kSZpUbQbjz7NC1o=.sha256 Matt McKegg · 11/2/2016, 9:17:01 AM

I've gone ahead and merged this as it is the easy answer, and bring it in line with the behavior of classic patchwork. But I would still like to keep this discussion going.

%Ye6sAWu89j0EjkuvWgoPKhXQEbdU2UwVl1u+lEmdn1o=.sha256 cel · 11/2/2016, 3:58:26 PM

I think closing to the tray would be good. This could lead us to letting the process auto launch on login and stay in the tray, so that user's don't have to remember to launch it.

%XOAwTJGNtHoiFjk7gO+IBItzDmth/zE0SqQpAoVgezY=.sha256 dinoworm ๐Ÿ› · 11/2/2016, 8:44:07 PM

yep, as a better long-term solution i'm keen to minimize to tray. :+1: this is what webtorrent-desktop does and it's quite nice for about the same reasons (it keeps peering your torrents).

%YUgbCB/9wETE1OMvs3v5oCXkgQrySjCy15d9u9IYZp4=.sha256 ansuz · 11/2/2016, 10:40:42 PM

But maybe this is me misunderstanding how people use "not mac"?

I launch everything from the terminal cause I'm a masochist.

Built with git-ssb-web