git ssb

30+

cel / git-ssb-web



frequent crashes

%eXT4WeA3I+Dm792EA/F8apZ7GHZxFmRvvAaePA+bP00=.sha256
ClosedKira opened this issue on 9/15/2017, 11:54:02 AM

frequent crashes

my git-ssb-web cli command terminates frequently (multiple times per day) with

Error: unexpected end of parent stream
    at PacketStream.destroy (/home/sww/.npm-global/lib/node_modules/git-ssb-web/node_modules/packet-stream/index.js:71:7)
    at PacketStream.write (/home/sww/.npm-global/lib/node_modules/git-ssb-web/node_modules/packet-stream/index.js:133:41)
    at /home/sww/.npm-global/lib/node_modules/git-ssb-web/node_modules/muxrpc/pull-weird.js:58:44
    at /home/sww/.npm-global/lib/node_modules/git-ssb-web/node_modules/pull-stream/sinks/drain.js:20:24
    at /home/sww/.npm-global/lib/node_modules/git-ssb-web/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:17:11
    at Object.cb (/home/sww/.npm-global/lib/node_modules/git-ssb-web/node_modules/packet-stream-codec/index.js:98:24)
    at drain (/home/sww/.npm-global/lib/node_modules/git-ssb-web/node_modules/pull-reader/index.js:42:23)
    at /home/sww/.npm-global/lib/node_modules/git-ssb-web/node_modules/pull-reader/index.js:59:18
    at Object.cb (/home/sww/.npm-global/lib/node_modules/git-ssb-web/node_modules/pull-box-stream/index.js:127:18)
    at drain (/home/sww/.npm-global/lib/node_modules/git-ssb-web/node_modules/pull-reader/index.js:39:14)
sbot client connection closed. aborting
%m3q2lVBfq/sgT3DbWiBdvyJFQ5ny5255tUYz/ekz4Sc=.sha256 mixmix · 9/15/2017, 12:10:39 PM

myeah I think I've hit this or similar. I think git-ssb chokes on larger repos.... e.g. patchbay. git-ssb-web does ... and from memory going further down the chain I hit some problems with it to.

Been meaning to dive back into that

%hx40FlEFxvuoEek+plFkRWH8T3EKuXhfrVeQcX7Vkls=.sha256 cel · 9/15/2017, 6:57:35 PM

@noffle This error looks like sbot's timeout disconnect. This should be fixed as of 8599df15928f4db206734f0d4ed00429e6b36a86

%L4EOS5+7LHSYNm+/kLkVIDcXqa/IjAxz2r7wHuNRje8=.sha256 Kira closed this issue · 9/17/2017, 10:09:58 PM

So far so good! I'll reopen if this persists. Thanks @cel.

%kMXkElsLWnPoj8uBloftmweZW3SQFfNOddn/VX/vZN4=.sha256 Kira reopened this issue · 9/18/2017, 6:49:36 PM

Still crashing in the same way, even on 8559df1. I noticed the word vote at the front though:

vote Error: unexpected end of parent stream
    at PacketStream.destroy (/home/sww/forks/git-ssb-web/node_modules/packet-stream/index.js:71:7)
    at PacketStream.write (/home/sww/forks/git-ssb-web/node_modules/packet-stream/index.js:133:41)
    at /home/sww/forks/git-ssb-web/node_modules/muxrpc/pull-weird.js:58:44
    at /home/sww/forks/git-ssb-web/node_modules/pull-stream/sinks/drain.js:20:24
    at /home/sww/forks/git-ssb-web/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:17:11
    at Object.cb (/home/sww/forks/git-ssb-web/node_modules/packet-stream-codec/index.js:98:24)
    at drain (/home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:42:23)
    at /home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:59:18
    at Object.cb (/home/sww/forks/git-ssb-web/node_modules/pull-box-stream/index.js:127:18)
    at drain (/home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:39:14)
Error: unexpected end of parent stream
    at PacketStream.destroy (/home/sww/forks/git-ssb-web/node_modules/packet-stream/index.js:71:7)
    at PacketStream.write (/home/sww/forks/git-ssb-web/node_modules/packet-stream/index.js:133:41)
    at /home/sww/forks/git-ssb-web/node_modules/muxrpc/pull-weird.js:58:44
    at /home/sww/forks/git-ssb-web/node_modules/pull-stream/sinks/drain.js:20:24
    at /home/sww/forks/git-ssb-web/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:17:11
    at Object.cb (/home/sww/forks/git-ssb-web/node_modules/packet-stream-codec/index.js:98:24)
    at drain (/home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:42:23)
    at /home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:59:18
    at Object.cb (/home/sww/forks/git-ssb-web/node_modules/pull-box-stream/index.js:127:18)
    at drain (/home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:39:14)
Error: unexpected end of parent stream
    at PacketStream.destroy (/home/sww/forks/git-ssb-web/node_modules/packet-stream/index.js:71:7)
    at PacketStream.write (/home/sww/forks/git-ssb-web/node_modules/packet-stream/index.js:133:41)
    at /home/sww/forks/git-ssb-web/node_modules/muxrpc/pull-weird.js:58:44
    at /home/sww/forks/git-ssb-web/node_modules/pull-stream/sinks/drain.js:20:24
    at /home/sww/forks/git-ssb-web/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:17:11
    at Object.cb (/home/sww/forks/git-ssb-web/node_modules/packet-stream-codec/index.js:98:24)
    at drain (/home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:42:23)
    at /home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:59:18
    at Object.cb (/home/sww/forks/git-ssb-web/node_modules/pull-box-stream/index.js:127:18)
    at drain (/home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:39:14)
Error: unexpected end of parent stream
    at PacketStream.destroy (/home/sww/forks/git-ssb-web/node_modules/packet-stream/index.js:71:7)
    at PacketStream.write (/home/sww/forks/git-ssb-web/node_modules/packet-stream/index.js:133:41)
    at /home/sww/forks/git-ssb-web/node_modules/muxrpc/pull-weird.js:58:44
    at /home/sww/forks/git-ssb-web/node_modules/pull-stream/sinks/drain.js:20:24
    at /home/sww/forks/git-ssb-web/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:17:11
    at Object.cb (/home/sww/forks/git-ssb-web/node_modules/packet-stream-codec/index.js:98:24)
    at drain (/home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:42:23)
    at /home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:59:18
    at Object.cb (/home/sww/forks/git-ssb-web/node_modules/pull-box-stream/index.js:127:18)
    at drain (/home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:39:14)
Error: unexpected end of parent stream
    at PacketStream.destroy (/home/sww/forks/git-ssb-web/node_modules/packet-stream/index.js:71:7)
    at PacketStream.write (/home/sww/forks/git-ssb-web/node_modules/packet-stream/index.js:133:41)
    at /home/sww/forks/git-ssb-web/node_modules/muxrpc/pull-weird.js:58:44
    at /home/sww/forks/git-ssb-web/node_modules/pull-stream/sinks/drain.js:20:24
    at /home/sww/forks/git-ssb-web/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:17:11
    at Object.cb (/home/sww/forks/git-ssb-web/node_modules/packet-stream-codec/index.js:98:24)
    at drain (/home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:42:23)
    at /home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:59:18
    at Object.cb (/home/sww/forks/git-ssb-web/node_modules/pull-box-stream/index.js:127:18)
    at drain (/home/sww/forks/git-ssb-web/node_modules/pull-reader/index.js:39:14)
sbot client connection closed. aborting
%aM+KK5WW0IMxPxQjoCzaTpnsKSxHOB/lvbkQFydrCaU=.sha256 cel · 9/18/2017, 7:13:58 PM

Ok, I guess the keepalive is not working. Maybe sbot locks up and then doesn't read the keepalive packet in time. Try updating secret-stack to >= c452ef70d47cff0dd337575bb5ad98c7f462c2eb? That should make it not disconnect the local RPC.

%RIHDjYyWUHhW5B4BbiT71Pjq0jihgzgGyq3uXStzMkY=.sha256 Kira · 9/22/2017, 5:20:22 PM

I upgraded scuttlebot, and now I see my machine running out of memory. Exciting!

[sww@nixos:~/forks/git-ssb-web]$ git-ssb-web
Listening on http://localhost:7718/
Issues state synced 7.377s

<--- Last few GCs --->

   76101 ms: Mark-sweep 1296.4 (1337.8) -> 1296.4 (1337.8) MB, 307.1 / 0.0 ms [allocation failure] [GC in old space requested].
   76411 ms: Mark-sweep 1296.4 (1337.8) -> 1296.4 (1337.8) MB, 310.6 / 0.0 ms [allocation failure] [GC in old space requested].
   76720 ms: Mark-sweep 1296.4 (1337.8) -> 1296.3 (1304.8) MB, 308.8 / 0.0 ms [last resort gc].
   77018 ms: Mark-sweep 1296.3 (1304.8) -> 1296.3 (1304.8) MB, 298.0 / 0.0 ms [last resort gc].


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x3a3ee73cfb51 <JS Object>
    1: linearize [/home/sww/.npm-global/lib/node_modules/git-ssb-web/node_modules/ssb-git/linearize.js:20] [pc=0x36a549cb9093] (this=0x3a3ee73e6111 <JS Global Object>,lists=0x18ee3b89be39 <JS Array[1]>,msg=0x3a3ee7304381 <undefined>)
    2: reduceLinks [/home/sww/.npm-global/lib/node_modules/git-ssb-web/node_modules/kvgraph/index.js:21] [pc=0x36a549cb8de7] (this=0x3a3ee73e6111 <JS Global Object...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [/run/current-system/sw/bin/node]
 2: 0xe0d721 [/run/current-system/sw/bin/node]
 3: v8::Utils::ReportApiFailure(char const*, char const*) [/run/current-system/sw/bin/node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [/run/current-system/sw/bin/node]
 5: v8::internal::Factory::NewUninitializedFixedArray(int) [/run/current-system/sw/bin/node]
 6: v8::internal::Factory::NewJSArrayStorage(v8::internal::Handle<v8::internal::JSArray>, int, int, v8::internal::ArrayStorageAllocationMode) [/run/current-system/sw/bin/node]
 7: v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, int, int, v8::internal::ArrayStorageAllocationMode, v8::internal::PretenureFlag) [/run/current-system/sw/bin/node]
 8: v8::internal::ElementsAccessor::Concat(v8::internal::Isolate*, v8::internal::Arguments*, unsigned int) [/run/current-system/sw/bin/node]
 9: 0x7d3b15 [/run/current-system/sw/bin/node]
10: 0x7f6df6 [/run/current-system/sw/bin/node]
11: 0x7f916a [/run/current-system/sw/bin/node]
12: 0x36a5496092a7
Aborted
%J1OOQth3lG/55EFNbYMG4uxVS2tBCV6lwP73rjyi4hI=.sha256 ev · 9/22/2017, 7:08:00 PM

@noffle This is scuttlebot@10.4.6? Let me try that out and see if I have the same issue.

%KBLVeaNhG2ZfCQ+BoGSL06wi8CWLf2io2EP1ednqM5I=.sha256 ev · 9/22/2017, 7:26:45 PM

I'm not seeing a noticeable difference between 10.4.4 and 10.4.6 memory usage over here... But I'm also using a client that only connects to sbot using ws, so maybe that's part of it?

%GHlmhfthAPzpyVNKfaEbbrsxpqQWVEXPa5LejtWMw2w=.sha256 Kira · 9/22/2017, 9:07:36 PM

@ev yes, that's correct.

%WMFs2AWAsb4huukmXDTJpGldzwbgbPxTBQYKaN0BE70=.sha256 Kira closed this issue · 12/8/2017, 7:57:08 PM

update: I haven't been seeing this anymore. I'll reopen if it crops up again.

Built with git-ssb-web