git ssb

9+

cel / ssb-viewer



I've noticed the about library built into ssb-viewer returns older images and names for ids.

%QzX0pnsPFTlkdxrgccCpc22NuNl/hViYWAvU1tPGVcI=.sha256
Openev opened this issue on 12/25/2016, 8:50:36 PM

I've noticed the about library built into ssb-viewer returns older images and names for ids.

Do you think upgrading to ssb-avatar will effect performance, @cel?

%nd/Kz9rHX4kd2fdxB5a6bQt8pBh3Gk4n5CysKQKoaaA=.sha256 cel · 12/26/2016, 5:00:43 PM

I made a new About implementation in ssb-viewer since I wasn't satisfied that ssb-avatar makes 4 sbot links queries per lookup. The implementation in ssb-viewer doesn't return older images and names, it returns the most recent ones, whereas the ssb-avatar implementation will always prefer an about message by the target feed, even if there are newer about messages by other feeds. I did a quick benchmark just now and didn't find significant performance difference. I would be okay with switching it to use ssb-avatar, for consistency with the other clients.

%N6FMRtZmrQunanWwrjLVZ0FIyzy0OrPCnoyRDkI5yY0=.sha256 ev · 12/26/2016, 7:38:51 PM

@cel Ok, I understand what's going on now.

I think it's worth not using ssb-avatar for the performance improvements.

Right now one of the slowest elements of Bay is the avatar query. Maybe a different idea would be to use this simpler avatar algorithm within Bay?

%tf1gNp0wYkEdUl3cI+KQK872RF69vkF33gYDffkEyM8=.sha256 Dominic · 12/26/2016, 11:57:10 PM

I've been thinking we should rewrite naming as a flumeview

ev mentioned this issue in Speed is also an issue with the naming algorithm. Right now avatars are the slowest thing to load in Bay. [@cel](@f/6sQ6d2CMxRUhLpspgGIulDxD
%dNmg/2jKqYRCcx4EXZEQ56clUUmNl2sakShjnL2hkkg=.sha256 arj · 5/11/2017, 7:39:13 PM

Think it would be a good idea to switch to ssb-avatar as someone went around and named a bunch of people wierd names :)

Built with git-ssb-web