git ssb - markdown: use html-escape on emoji attributes instead of incorrect encoding

Matt McKegg committed on 6/3/2017, 4:51:27 AM
Parent: e88968184cc1392c4b3b1ebb85d0a3b0e0523b13

message/html/markdown.js	changed
package.json	changed

message/html/markdown.jsView
		@@ -1,8 +1,9 @@
1	1 …	const renderer = require('ssb-markdown')
2	2 …	const h = require('mutant/h')
3	3 …	const ref = require('ssb-ref')
4	4 …	const nest = require('depnest')
	5 …	+var htmlEscape = require('html-escape')
5	6 …
6	7 …	exports.needs = nest({
7	8 …	'blob.sync.url': 'first',
8	9 …	'emoji.sync.url': 'first'
		@@ -48,11 +49,11 @@
48	49 …	function renderEmoji (emoji, url) {
49	50 …	if (!url) return ':' + emoji + ':'
50	51 …	return `
51	52 …	<img
52		- src="${encodeURI(url)}"
53		- alt=":${escape(emoji)}:"
54		- title=":${escape(emoji)}:"
	53 …	+ src="${htmlEscape(url)}"
	54 …	+ alt=":${htmlEscape(emoji)}:"
	55 …	+ title=":${htmlEscape(emoji)}:"
55	56 …	class="emoji"
56	57 …	>
57	58 …	`
58	59 …	}
WritePreview

dinoworm 🐛 / patchcore