Nice one ! merged
is this resolved @cryptix ?
merged into 6.9.0
Wow it is disturbingly fast. I thought the slow search was fun, but this is more like the offline web!
- ☐ highlighting
- ☐ search 'members' and it doesn't highlight 'members' (is this a reflection of the underlying search
- ☐ it's highlighting the channel name on messages too?
- ☐ README
- ☐ can you add an install not to the sbot setup (plugins.install) and maybe note which ones are optional (I don't know)
- ☐ flume
- ☐ is any of this going to be effected with the introduction of flume?
- ☐ needs master merged in. I made some simple changes to the search page, lemme know if anything needs clarifying.
@cel this is awesome
patchwork-next implements search on anything that doesn't have a sigil (# & %) - I think it's a much kinder default and wouldn't cost us anything to implement (that I can see).
Reviewing code now while some index builds. Sidenote - when sbot starts I would love a key of what the different chars spewing by are, e.g.
x : message index + : search index . : message synce
(made up, I have no idea!)
I honestly couldn't simulate this, but trust what you're saying. I get the feeling a bunch of this is going to need dedicated attention and deeper problem-solving at some stage. It could be that the
mcssgives gets split into
mcss_mobileat some stage in the future...
as far as I know, styling inside of iframes is not a thing right ? Looking really good. I've added an MCSS pattern to this
seems stable, looks great. merging !
will release with some other small changes shortly
smoke-tested this. Patchbay seems stable with it, will merge.
For futre reference, can you push to a branch on Dominic/patchbay - it will make it easier for me to fetch out your work :)
This pull request looks really interesting. It also looks like it's pre-depject 3 D:
Cel are you interested in seeing if this can be brough up to date, or shall we leave this for now?
hey arj, tried rebasing this on top of most recent changes. Haven't been able to get this to work nicely on my machine - it seems to shift the lightbox to the right hand side of a the screen.
Maybe have a go brining this up to date and get back to us?
Also notice you've got a few different things going on here which don't need to all be in the same PR (I don't think). e.g. I think the version bumps look like a good idea, but the styling not working means we have to wait on the stlying before bumping those
Built with git-ssb-web