Thanks, I think we can leave memo as it is now.
@dominic what do you think about this patch? I guess you are the only one qualified to review it :)
I'm trying this PR and just searched for something random using ?tor in the search box and got the following error:
Error: not ready at Object.search (/home/arj/.ssb/node_modules/ssb-fulltext/fulltext.js:78:37) at Object.search (/home/arj/.ssb/node_modules/ssb-fulltext/index.js:29:25) at Object.hooked (/home/arj/.nvm/versions/node/v7.3.0/lib/node_modules/scuttlebot/node_modules/hoox/index.js:10:15) at Object.localCall (/home/arj/.ssb/node_modules/ssb-ws/node_modules/muxrpc/local-api.js:31:31) at Object.<anonymous> (/home/arj/.ssb/node_modules/ssb-ws/node_modules/muxrpc/local-api.js:37:22)
Are you running this patch? Because it should fix the problem I think:
After checkout of the repo (thanks @cryptix) I'm getting this error when running lite client: export declared but not returnedsbot_fulltext_search in:sbot.js. Did you forget to commit something?
This one should fix this github issue https://github.com/ssbc/patchbay/issues/63
Same problem here.
Ok. I'll do seperate PRs. Thanks for testing :)
Okay, that makes more sense :)
@dominic what do you think, can this be merged in? I'm eager to see if it improves the random connection problems people are seeing.
Thanks for testing @ev!
@ev is this plain sbot or do you have any local patches? Because with this patch, patchbay and sbot has been much more stable for me. I added a ton of debug to the gossipping code to find the problem is, and there is definitely a problem in that part of the code. But it might be harder for other clients to trigger. Then again, I see some wierd "end of parent stream" and handshake problems that might be related to this if the connection is closed during connect.
I'm closing this one as things look much better in the mix mix branch.
This should be fixed in 2.6.5
You can have a look in my fixes branch. There are some more fixes. This is all the fixes I'm running atm. included this one: https://github.com/arj03/hyperlightbox
This sounds like a good idea, any reason this has not been merged?
I made a patch for that in my branch for this.
@mixmix I had the same problem and spent some time tracking it down. The way localization works in git-ssb-web is that it uses the accept-headers sent from the browser and tries to find a corresponding <LANG>.json in static/locale. And if it doesn't find the file, it falls back to 'en'. I quick workaround is simply creating a <LANG>.json file for your local, but I don't think that is the correct approach. It should use the local time no matter if there is a translation or not. I'll make a patch for that but until then, you can use my workaround.
Ahh it is running tor right? asf2e525q57piquz.onion
I'm running with the patch now and it connects to mindeco.de besides my own pub. Is this yours @cryptop and do you have tor running on your pub?
The really wierd thing is that I've been moving over to a Chromebook and have been running patchbay for the last week or so but it has been running really slow and often simply refuses connections so I have to restart sbot. But with --tor-only and this patch everything is running much more smoothly. Loading my feed is much faster and I havn't seen any problems yet. Any idea why that could be @dominic?
This works @cryptop :)
Seems like you are correct in that it doesn't work locally. I made this for my pub which has no need to talk to other sbot instance on localhost and that works fine.
I tested the patch you posted and that does not work.
I'll see if we can do something else.
Sneaked in another commit. Patchbay is really easy to hack on :)
Same problem in original patchwork that also uses persistent-gossip.
This would be really cool, especially when combined with the web interface. Maybe even some kind of firefox add-on that can show this information?
That would be one way. Would you accept such a patch?
I was just thinking of something more general, but thinking more about it I think we are over in the whole group concept thing. We should be careful with a false sense of security.
Built with git-ssb-web