hacked together the external url confirmation we talked about on the last call.
if this is applied, it prompts you with a lightbox showing the external href in a
clicking ok opens the link, cancel does nothing but hiding the lightbox.
viewing this PR in git-ssb-web shows a lot more commits then I intended.
actually just one (
b9c788b5..) and it's parent is v6.1.6 (
still not sure why it goes back to
a168beb1551b3abbd4db5b2ccc4bd53583876661 on git-ssb-web...
66be6771· 1/4/2017, 4:51:37 PM
force pushed after rebasing on %wDwuVXp....
- git.scuttlebot.io link because i get oom errors locally
c688a8d2· 1/4/2017, 11:16:09 PM
okay.. afaict this works as intended. review welcome!
I included a small and unrelated patch to the about_refactor. It stopped looking up the
message_name and only showed the key... I'm not sure how we want to deal with small patches like these. To me they are typo-like because they regress old behavior. Last time I made a sperate branch and PR for these they fell into oblivion, which could also be a result of my insufficient communication...
968dba2f· 1/10/2017, 7:36:31 PM
Merged this manually. Looks great :tropical fish:
Built with git-ssb-web