git ssb


10+

Dominic / patchbay



hacked together the external url confirmation we talked about on the last call.

%d72X3B562coWpUOQE6qQsTPiT4Ykm45atkyDPvNwmbc=.sha256
Closed cryptop wants to merge commits into master from externalConfirm
cryptop · 1/4/2017, 4:09:45 PM

hacked together the external url confirmation we talked about on the last call.

if this is applied, it prompts you with a lightbox showing the external href in a <pre> tag.

clicking ok opens the link, cancel does nothing but hiding the lightbox.

%MVNWQJpZhF1+cCOTVgW3ArQPDiSsxfaaPOlJ/a+tpWw=.sha256 cryptop · 1/4/2017, 4:16:15 PM

whoops...

viewing this PR in git-ssb-web shows a lot more commits then I intended.

%ZLtaxBgotU5jqTCszLyr4HvGagHftN7EYEpyhBhyf7c=.sha256 cryptop · 1/4/2017, 4:22:36 PM

actually just one (b9c788b5..) and it's parent is v6.1.6 (5cb4510e7266ce92c57a4468efce4479ec64d714)..

still not sure why it goes back to a168beb1551b3abbd4db5b2ccc4bd53583876661 on git-ssb-web...

justOneCommit.png

cryptop updated the branch to 66be6771 · 1/4/2017, 4:51:37 PM
%4EBH55jOKQnZU5f+Bjz7lz28Nw/sv+aBngm22OK0nps=.sha256 cryptop · 1/4/2017, 4:52:31 PM

force pushed after rebasing on %wDwuVXp....

%TbflCWQ1k5VzDvK2KZtYhAb5oow2Y1NumSy751P3rJ0=.sha256 cryptop · 1/4/2017, 8:13:04 PM

and now it shows up as a single commit in git-ssb-web(*) so this might have been a fluke...

cryptix updated the branch to c688a8d2 · 1/4/2017, 11:16:09 PM
%dUZlCjeCxVZ7ml8DtPKKGcKB9AOofXKAq8wdA0SvJSI=.sha256 cryptix · 1/5/2017, 12:35:39 PM

okay.. afaict this works as intended. review welcome!

I included a small and unrelated patch to the about_refactor. It stopped looking up the message_name and only showed the key... I'm not sure how we want to deal with small patches like these. To me they are typo-like because they regress old behavior. Last time I made a sperate branch and PR for these they fell into oblivion, which could also be a result of my insufficient communication...

cryptix mentioned this pull request in I'd like to purpose talking about [secure liteclient deployment](%4jkdqfkC9iEUt9CY5kZybL9LlyPdm7nU2idJ7Mpj+1g=.sha256). Maybe we can revisit
cryptix updated the branch to 968dba2f · 1/10/2017, 7:36:31 PM
%xufQ5G4Lx/etTIB1oidVoYMzBBGKiB9DL3OqOfh+M9A=.sha256 mix · 1/12/2017, 4:00:35 AM

Merged this manually. Looks great :cactus: :tropical fish:

%DjRKZY+MzVyApbpNk7apGl7wJgqq9IZJ72A8qo1+Gl4=.sha256 mix closed this pull request · 1/12/2017, 4:00:39 AM
%kMh82R53+fKCUbNz7SYadjs5fL0FtibvS2QsGxYXVrA=.sha256 cryptix · 1/12/2017, 4:42:53 AM

thanks! :heart_eyes_cat:


Built with git-ssb-web