git ssb


3+

Dominic / scuttlebot



This fixes the hist stream crash. It changes the behavior to include all keys in the hist stream with values:false, whereas when the values are present, the stream is cut off if the feed blocked...

%5593FpQ0xbo0u1FIHuop5X8fl5GBblhtt3K2UJlHu8o=.sha256
Closed cel wants to merge commits into master from Dominic / %ccrX9uZ2173/xsDbtTM… / master
cel · 7/25/2016, 5:58:49 PM

This fixes the hist stream crash. It changes the behavior to include all keys in the hist stream with values:false, whereas when the values are present, the stream is cut off if the feed blocked the current user.

%/XRr6AWeRisth37rMtOsVDpBC6iXMTxJWEvXBppKh8I=.sha256 Dominic · 10/29/2016, 9:11:11 AM

hmm, this actually breaks block, well half breaks it, because a blocked user cannot do a createHistoryStream, but can do createHistoryStream with keys true. They'll get the keys, but not the values. Instead, I think we should just disable history stream without values.

%+Kmvwk1fwjJN9VTQWvcC49mcZk6MM6wCCdWEuDaydCw=.sha256 cel · 11/30/2016, 11:06:31 AM

I realized it's okay if hist without values doesn't work, because createUserStream can be used for that.

However, I'm not sure I understand the behavior of block in this context. It looks like this says, if I see you block me, I will stop replicating your feed. Shouldn't it instead be that I stop replicating your feed only if I block you? and so the information about whether to replicate your feed comes from my feed, not yours? (and maybe should come from the feeds I follow, as well, but that could be a different discussion)

%3kU8TyK3ph9BAE9XWZiufFAviaa+TaCydcebY47KzFw=.sha256 Dominic · 12/1/2016, 12:59:03 AM

the original intention was that block prevented them from seeing your data. which is how twitter block works. This requires your peers to also not give your data to them.

· 6/23/2017, 11:17:39 PM

Built with git-ssb-web